Macro will not execute consistently

[streub]

I am using this macro to calculate the percentage savings on a template. The macro does not execute consistently and the percent formatted control does not always display the percentage (%) symbol. I have used several events but with no success.

Code: Select all

REM  *****  BASIC  *****


Sub oPct

	oDoc = ThisComponent'Clearance Tag
	oDocView = oDoc.getCurrentController()

	oForm = oDoc.drawpage.forms(0)

		tbp = oForm.getbyname("tbp")'percent discount
		tbr = oForm.getbyname("tbr")'retail price
		tbd = oForm.getbyname("tbd")'discounted price
		
		tbp.text  = (tbr.value - tbd.value) / tbr.value *  100
		
End Sub
[code]

The file is too large to attach.

Thank you in advance for the assistance.

Streub

[UnklDonald418]

Debugging a “macro does not execute consistently ” is difficult. Out of context, nearly impossible.
I would add a line

Code: Select all

temp = (tbr.value - tbd.value) / tbr.value * 100 

just before

Code: Select all

tbp.text = (tbr.value - tbd.value) / tbr.value * 100 

In the IDE set a break point on the second line and a watch on the variable temp.
If the macro fails to execute then you know the problem is definitely Event related.
If the value shown for temp isn't what you expect, then you will need to watch the values used in the calculation.
If, when using the IDE with the break point, the macro always works you could try inserting a delay something like Wait 200 just before the second line above.

[Villeroy]

Code: Select all

x = tbr.value
y = tbd.value
temp = (x - y) / x

REM if tbp happens to be a formattable control for numeric content
REM you can format that thing as percent value and set its numeric value
tbp.Value = temp